Build multiple artifacts for the example document #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
force-pushed
the
build-additional-artifacts
branch
from
8e381f1 to
22ccc1e
Compare
tarleb
reviewed
Sep 16, 2024
| name: paper | ||
| path: example/paper.context.pdf | ||
| name: draft | ||
| path: | |
There was a problem hiding this comment.
Note to self: we should find a way to return the name of the generated files, so we don't have to maintain this manually.
There was a problem hiding this comment.
I tried to do it with a ** glob pattern but that didn't work after a few tries so I went back to manually listing them
|
I'd prefer not to change |
Agreed, these diffs make it harder to review over time. I think I just had to change the file to trigger then PR, and PyCharm aggressively reformatted it. I just reverted it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extends the GitHub Action that builds the PDF for the example document to also build other artifacts.
Before, it only build
contextpdfbut now it also buildsjats,crossref,pdf, andpreprint. Additionally, it now builds both the draft flavor and the production flavor (by adding-p). Each gets put into their own "artifact"Why - I'm still trying to wrap my head around the testing suite and having the GitHub Actions environment be able to report back what its builds look like seems like a good step in that direction